feat(compactor-hs): add a metric to track the number of jobs left to conclude ongoing unit of work - #19506
Merged
Merged
Conversation
paul1r
approved these changes
Oct 15, 2025
This was referenced Jun 23, 2026
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
…conclude ongoing unit of work (grafana#19506)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I am working on adding autoscaling support to compactor workers. To estimate the number of replicas required to perform the ongoing work, I have added a metric to track the estimated number of jobs left to be processed.
Since compactor processes only one segment at a time, we will estimate the deletion job count and track it in the metric only for the segment currently being processed. If we count all the jobs that would be created for the entire deletion manifest and autoscale on that, we would have some workers running idle.
Checklist