feat(helm): Only delete PVC on statefulset deletion, not scaling

[cwrau]

What this PR does / why we need it:

Users using the single binary deployment mode don't want to lose their data during scaling (to zero)

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• Title matches the required conventional commits format, see here
  • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[CLAassistant]

All committers have signed the CLA.

[cwrau]

Heyho, is there something I can do to help get this merged?

[jkroepke]

and please add a note to the CHANGELOG

[cwrau]

I tried running make helm-docs but it returned the following error;

make -BC docs sources/setup/install/helm/reference.md
make[1]: Entering directory '/home/cwr/projects/loki/docs'
podman run --rm --volume "/home/cwr/projects/loki:/helm-docs" -u "$(id -u)" "docker.io/jnorwood/helm-docs:v1.11.0" \
	-c /helm-docs/production/helm/ \
	-t reference.md.gotmpl \
	-o reference.md
podman run --rm --volume "/home/cwr/projects/loki:/helm-docs" -u "$(id -u)" "docker.io/jnorwood/helm-docs:v1.11.0" \
	-c /helm-docs/production/helm/ \
	-t README.md.gotmpl \
	-o README.md
mv "../production/helm/loki/reference.md" "sources/setup/install/helm/reference.md"
time="2025-09-19T07:32:22Z" level=info msg="Found Chart directories [loki]"
time="2025-09-19T07:32:22Z" level=info msg="Generating README Documentation for chart /helm-docs/production/helm/loki"
time="2025-09-19T07:32:22Z" level=warning msg="Could not open chart README file /helm-docs/production/helm/loki/README.md, skipping chart"
time="2025-09-19T07:32:23Z" level=info msg="Found Chart directories [loki]"
time="2025-09-19T07:32:23Z" level=info msg="Generating README Documentation for chart /helm-docs/production/helm/loki"
time="2025-09-19T07:32:23Z" level=warning msg="Could not open chart README file /helm-docs/production/helm/loki/README.md, skipping chart"
mv: cannot stat '../production/helm/loki/reference.md': No such file or directory
make[1]: *** [Makefile:16: sources/setup/install/helm/reference.md] Error 1
make[1]: Leaving directory '/home/cwr/projects/loki/docs'
make: *** [Makefile:260: helm-docs] Error 2

[jkroepke]

Maybe the podman integration is broken. It seems volume permissions are not respected?

[cwrau]

Maybe the podman integration is broken. It seems volume permissions are not respected?

I have no Idea, but BUILD_IN_CONTAINER=false make helm-docs worked after I installed helm-docs 👍

[jkroepke]

LGTM

[nicolevanderhoeven]

LGTM