fix(helm): avoid double zonal ingester scrapping by not scrapping headless svc - #19000
Merged
JStickler merged 2 commits intoSep 3, 2025
Merged
Conversation
|
|
antonincms
force-pushed
the
fix-zonal-ingester-metrics-double-scrapping
branch
2 times, most recently
from
August 25, 2025 12:57
3dd36b4 to
c7f406c
Compare
JStickler
changed the title
Contributor
Author
|
Thanks for running the CI @JStickler. I have the impression that "Claude Code Review" job fails for a reason unrelated to this PR: it fails pulling the token, probably because this PR come from a fork. |
Contributor
|
@antonincms yes, that's exactly why the Claude check is failing; forks don't have access to our secrets in Vault. The Claude check was introduced last week, and still needs to be adjusted. You don't need to worry about it, it's not part of the failCheck (that is, it's not a blocker). |
Contributor
|
LGTM. Thank you very much! |
6 tasks
antonincms
force-pushed
the
fix-zonal-ingester-metrics-double-scrapping
branch
from
August 28, 2025 09:27
c7f406c to
fcf0b57
Compare
antonincms
force-pushed
the
fix-zonal-ingester-metrics-double-scrapping
branch
from
August 28, 2025 09:28
fcf0b57 to
90070dd
Compare
Contributor
Author
|
Just rebased my PR onto main, I think it should be ok now. |
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
This was referenced Jun 23, 2026
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
…dless svc (grafana#19000) Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix zonal ingester being scrapped twice when using ServiceMonitor.
Which issue(s) this PR fixes:
Fixes #18996
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR