Skip to content

fix(deps): update dskit dependency - #18711

Merged
fcjack merged 3 commits into
mainfrom
fcjack/update-dependencies
Aug 4, 2025
Merged

fix(deps): update dskit dependency#18711
fcjack merged 3 commits into
mainfrom
fcjack/update-dependencies

Conversation

@fcjack

@fcjack fcjack commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The current main branch is failing after the update with dskit, using the latest version and building the app locally is working properly

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@fcjack fcjack self-assigned this Aug 4, 2025
@fcjack fcjack added the dependencies Pull requests that update a dependency file label Aug 4, 2025
@fcjack fcjack changed the title update dskit Aug 4, 2025
@fcjack fcjack changed the title deps: update dskit dependency Aug 4, 2025
@github-actions

github-actions Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

💻 Deploy preview deleted.

@fcjack
fcjack marked this pull request as ready for review August 4, 2025 10:09
@fcjack
fcjack requested a review from a team as a code owner August 4, 2025 10:09
@fcjack
fcjack merged commit 19233d0 into main Aug 4, 2025
93 of 120 checks passed
@fcjack
fcjack deleted the fcjack/update-dependencies branch August 4, 2025 12:34
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size/XS

2 participants