fix(helm): Add release namespace metadata to HorizontalPodAutoscaling that lack it - #18453
Merged
Merged
Conversation
… that lack it Signed-off-by: Rhea Danzey <rdanzey@element.io>
5 tasks
Contributor
Author
|
Thank you!! |
This was referenced Nov 3, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
… that lack it (grafana#18453) Signed-off-by: Rhea Danzey <rdanzey@element.io> Co-authored-by: J Stickler <julie.stickler@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I've noticed when using a combination of ArgoCD and Helmfile to deploy Loki in it's own namespace, the HPA resource for the
readcomponent gets created in the ArgoCD Application's default namespace, while all of the other Loki components that get deployed are in the proper namespace I've set in the Helmfile.As long as the Helm template for the resource has
namespace: {{ .Release.Namespace }}, this works as I'd expect it, but I noticed that while a lot of the HPA resource templates in this chart have this configured, a few including thereadHPA that just confused me do not have it in the template. I flipped through the components and remedied all the HPAs I could see by filename, though there could be more resources throughout the chart that have similar behavior that I've yet to find.This is probably not exclusive to ArgoCD or Helmfile, but any deployment scenario relying on Helm to deploy to the specified
-n/--namespaceswitch rather than the current Kubeconfig default namespace will probably do the same thing. HPA resources will have a status similar to:as the HPA resource needs to be in the same namespace as the deployment resource.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR