fix(operator): Fix type of maximum OpenShift version property - #18066
Merged
Conversation
xperimental
requested review from
a team,
JoaoBraveCoding and
periklis
as code owners
June 11, 2025 13:23
periklis
approved these changes
Jun 11, 2025
This was referenced Aug 11, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we pass in the maximum version as a number, which has worked for the previous releases, but stops working with 4.20, because it is parsed as
4.2. This PR fixes this by changing the type to a string.Which issue(s) this PR fixes:
Fixes LOG-7299
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)