Skip to content

fix: counter variables should not have total at the end - #17982

Merged
grobinson-grafana merged 1 commit into
mainfrom
grobinson/fix-var-name
Jun 4, 2025
Merged

fix: counter variables should not have total at the end#17982
grobinson-grafana merged 1 commit into
mainfrom
grobinson/fix-var-name

Conversation

@grobinson-grafana

@grobinson-grafana grobinson-grafana commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The variables for counters should not have total at the end (as per examples in https://pkg.go.dev/github.com/prometheus/client_golang/prometheus).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@grobinson-grafana
grobinson-grafana requested a review from a team as a code owner June 4, 2025 19:56
@grobinson-grafana
grobinson-grafana enabled auto-merge (squash) June 4, 2025 20:03
@grobinson-grafana
grobinson-grafana merged commit 9dd14ba into main Jun 4, 2025
@grobinson-grafana
grobinson-grafana deleted the grobinson/fix-var-name branch June 4, 2025 20:06
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants