Skip to content

fix(ruler): Return StatusBadRequest on multiple org IDs - #17850

Merged
periklis merged 2 commits into
mainfrom
fix-ruler-multiple-orgids
Jun 2, 2025
Merged

fix(ruler): Return StatusBadRequest on multiple org IDs#17850
periklis merged 2 commits into
mainfrom
fix-ruler-multiple-orgids

Conversation

@periklis

@periklis periklis commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This pull request provides a small fix to return BadRequest as the status code when a client if sending multiple org ids to the ruler API.

Which issue(s) this PR fixes:
Fixes #grafana/loki-private/issues/1335

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@periklis
periklis force-pushed the fix-ruler-multiple-orgids branch from 0d14b07 to 22179ab Compare June 2, 2025 07:43
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jun 2, 2025
@periklis
periklis marked this pull request as ready for review June 2, 2025 07:43
@periklis
periklis requested a review from a team as a code owner June 2, 2025 07:43
@periklis periklis self-assigned this Jun 2, 2025
ashwanthgoli
ashwanthgoli approved these changes Jun 2, 2025
View reviewed changes

@ashwanthgoli ashwanthgoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@periklis
periklis merged commit f7e47f0 into main Jun 2, 2025
@periklis
periklis deleted the fix-ruler-multiple-orgids branch June 2, 2025 07:56
@periklis periklis added type/bug Somehing is not working as expected backport k257 labels Jun 2, 2025
loki-gh-app Bot pushed a commit that referenced this pull request Jun 2, 2025
@periklis grafana-delivery-bot[bot]
fix(ruler): Return StatusBadRequest on multiple org IDs (#17850)
b832023 
(cherry picked from commit f7e47f0)
@loki-gh-app loki-gh-app Bot mentioned this pull request Jun 2, 2025
Merged
6 tasks
This was referenced Aug 5, 2025
Closed
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Aug 18, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 1, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 8, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 15, 2025
Closed
@loki-gh-app loki-gh-app Bot mentioned this pull request Sep 22, 2025
Closed
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
@periklis
fix(ruler): Return StatusBadRequest on multiple org IDs (grafana#17850)
1c486a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k257 size/L type/bug Somehing is not working as expected

2 participants

@periklis @ashwanthgoli