fix(limits): Read the consumer group and topic from the ingest-limits config - #17831
Merged
Conversation
periklis
force-pushed
the
use-cfg-consumer-group
branch
from
May 27, 2025 12:04
648566c to
bce467e
Compare
periklis
marked this pull request as ready for review
May 27, 2025 12:04
grobinson-grafana
requested changes
May 27, 2025
Contributor
|
💻 Deploy preview deleted. |
Contributor
|
Looks good but I think you also need to remove this function: // MetadataTopic returns the metadata topic name for the given topic.
func MetadataTopic(topic string) string {
return topic + ".metadata"
}and update its usage in different places like the stream generator. |
periklis
commented
May 29, 2025
grobinson-grafana
approved these changes
Jun 2, 2025
| // Make a copy of the streams from the request. We will prune this slice | ||
| // each time we receive the responses from a zone. | ||
| streams := make([]*proto.StreamMetadata, 0, len(req.Streams)) | ||
| for _, stream := range req.Streams { |
periklis
enabled auto-merge (squash)
June 2, 2025 08:00
Merged
6 tasks
This was referenced Aug 5, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request enables a separate configuration of the topic and consumer-group for the ingest-limits service. This enables to separate consumers from other components like partition-ingesters.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR