fix(operator): update webhook validator for alerts/rules - #17824
Merged
Conversation
infrastructure queries to not have a namespace label
JoaoBraveCoding
requested review from
a team,
periklis and
xperimental
as code owners
May 26, 2025 16:00
6 tasks
xperimental
approved these changes
May 26, 2025
xperimental
left a comment
xperimental
left a comment
Collaborator
There was a problem hiding this comment.
Works as expected using the AlertingRule from the issue 👍
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Jul 9, 2025
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Jul 9, 2025
JoaoBraveCoding
added a commit
to JoaoBraveCoding/loki
that referenced
this pull request
Jul 9, 2025
This was referenced Aug 5, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update the webhook validator of alerts/rules to allow infrastructure queries to not have a namespace label
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/LOG-6862
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR