fix: set delete request batch to empty when we load to fail requests - #17810
Merged
Conversation
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
chaudum
approved these changes
May 23, 2025
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
chaudum
approved these changes
May 23, 2025
This was referenced Aug 5, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
…rafana#17810) Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When we fail to load delete requests, we set DeleteRequestsManager.currentBatch to
nil, which would lead to panics when we try to do any operation on the batch.I have changed the code to set it to an empty batch when we fail to load the delete requests.