Skip to content

fix(limits): Adapt defaults and expose evict interval - #17808

Merged
periklis merged 5 commits into
mainfrom
ingest-limits-active-window
May 26, 2025
Merged

fix(limits): Adapt defaults and expose evict interval#17808
periklis merged 5 commits into
mainfrom
ingest-limits-active-window

Conversation

@periklis

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This pull request adapts the default active window for the ingest-limits service from 1h to 2h. With the redesign to synchronous ingest-limits writes the new default represents the same length of active streams in classic ingesters. In addition the evict internal is exposed as a custom config decoupled from the choice of the active window.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@periklis periklis self-assigned this May 23, 2025
@periklis
periklis requested a review from a team as a code owner May 23, 2025 07:22
@github-actions

github-actions Bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

💻 Deploy preview deleted.

@periklis
periklis force-pushed the ingest-limits-active-window branch from 9e09be4 to bade8f0 Compare May 23, 2025 07:27
Comment thread pkg/limits/config.go Outdated
Comment thread pkg/limits/config.go Outdated
@periklis
periklis merged commit d690664 into main May 26, 2025
@periklis
periklis deleted the ingest-limits-active-window branch May 26, 2025 11:22
@periklis periklis added type/bug Somehing is not working as expected backport k256 labels May 26, 2025
loki-gh-app Bot pushed a commit that referenced this pull request May 26, 2025
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport k256 size/S type/bug Somehing is not working as expected

2 participants