fix(limits): Adapt defaults and expose evict interval - #17808
Merged
Conversation
Contributor
|
💻 Deploy preview deleted. |
periklis
force-pushed
the
ingest-limits-active-window
branch
from
May 23, 2025 07:27
9e09be4 to
bade8f0
Compare
grobinson-grafana
approved these changes
May 23, 2025
loki-gh-app Bot
pushed a commit
that referenced
this pull request
May 26, 2025
(cherry picked from commit d690664)
6 tasks
This was referenced Aug 5, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adapts the default active window for the ingest-limits service from
1hto2h. With the redesign to synchronous ingest-limits writes the new default represents the same length of active streams in classic ingesters. In addition the evict internal is exposed as a custom config decoupled from the choice of the active window.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR