fix(helm): Fixed statement logic to enable annotations - #17756
Merged
JStickler merged 3 commits intoMay 22, 2025
Conversation
Signed-off-by: Dmitry Ponomaryov <me@halje.ru>
Contributor
Author
|
@JStickler hi! could you please let me know if anything needs to be changed in my PR for it to be approved? this is my second PR, and I haven’t received any feedback yet. i’d really appreciate your input. |
Contributor
|
@iamhalje I'm the technical writer on the team, but I'll try to grab one of the engineers to look at this for you. |
Contributor
|
LGTM just running our background tests |
Jayclifford345
approved these changes
May 22, 2025
Contributor
Author
@Jayclifford345 running test from makefile, check grafana/loki-release for check what pipelines failed, not see in logs anything, but my change not can be fail, help what problem? |
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
Signed-off-by: Dmitry Ponomaryov <me@halje.ru> Co-authored-by: J Stickler <julie.stickler@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #10528
Special notes for your reviewer:
PR #10388 copies logic from one template to others, but due to this, it's impossible to reach that logic because of incorrect conditions
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR