Skip to content

fix(helm): Fixed statement logic to enable annotations - #17756

Merged
JStickler merged 3 commits into
grafana:mainfrom
hautestacky:helm-fix-annotations-statement
May 22, 2025
Merged

fix(helm): Fixed statement logic to enable annotations#17756
JStickler merged 3 commits into
grafana:mainfrom
hautestacky:helm-fix-annotations-statement

Conversation

@hautestacky

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #10528

Special notes for your reviewer:
PR #10388 copies logic from one template to others, but due to this, it's impossible to reach that logic because of incorrect conditions

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
Signed-off-by: Dmitry Ponomaryov <me@halje.ru>
@hautestacky
hautestacky requested a review from a team as a code owner May 20, 2025 07:49
@hautestacky

Copy link
Copy Markdown
Contributor Author

@JStickler hi! could you please let me know if anything needs to be changed in my PR for it to be approved? this is my second PR, and I haven’t received any feedback yet. i’d really appreciate your input.

@JStickler

Copy link
Copy Markdown
Contributor

@iamhalje I'm the technical writer on the team, but I'll try to grab one of the engineers to look at this for you.

@Jayclifford345 Jayclifford345 self-assigned this May 22, 2025
@Jayclifford345

Copy link
Copy Markdown
Contributor

LGTM just running our background tests

@hautestacky

hautestacky commented May 22, 2025

Copy link
Copy Markdown
Contributor Author

just running our background tests

@Jayclifford345 running test from makefile, check grafana/loki-release for check what pipelines failed, not see in logs anything, but my change not can be fail, help what problem?

@JStickler
JStickler merged commit 3c34af3 into grafana:main May 22, 2025
felix0102 pushed a commit to felix0102/loki that referenced this pull request Aug 2, 2026
Signed-off-by: Dmitry Ponomaryov <me@halje.ru>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants