fix(docs): Update configuration.md - #17269
Merged
Merged
Conversation
Corrected keep-file description true and false notes. Signed-off-by: Mitch Nemirovsky <7938872+mitchnemirov@users.noreply.github.com>
paul1r
approved these changes
Apr 17, 2025
Collaborator
|
Doc change appears to be correct, the default is false: Thank you for the submission! |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-17269-to-release-3.1.x origin/release-3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 70de5235b7c0e5a549f4bbc7cd127956d595badbWhen the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-17269-to-release-3.1.x
# Create the PR body template
PR_BODY=$(gh pr view 17269 --json body --template 'Backport 70de5235b7c0e5a549f4bbc7cd127956d595badb from #17269{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'fix(docs): Update configuration.md (backport release-3.1.x)' --body-file - --label 'size/XS' --label 'type/docs' --label 'backport' --base release-3.1.x --milestone release-3.1.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-17269-to-release-3.1.x
# Create a pull request where the `base` branch is `release-3.1.x` and the `compare`/`head` branch is `backport-17269-to-release-3.1.x`.
# Remove the local backport branch
git switch main
git branch -D backport-17269-to-release-3.1.x |
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Mitch Nemirovsky <7938872+mitchnemirov@users.noreply.github.com> (cherry picked from commit 70de523)
6 tasks
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-17269-to-release-3.0.x origin/release-3.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 70de5235b7c0e5a549f4bbc7cd127956d595badbWhen the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-17269-to-release-3.0.x
# Create the PR body template
PR_BODY=$(gh pr view 17269 --json body --template 'Backport 70de5235b7c0e5a549f4bbc7cd127956d595badb from #17269{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'fix(docs): Update configuration.md (backport release-3.0.x)' --body-file - --label 'size/XS' --label 'type/docs' --label 'backport' --base release-3.0.x --milestone release-3.0.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-17269-to-release-3.0.x
# Create a pull request where the `base` branch is `release-3.0.x` and the `compare`/`head` branch is `backport-17269-to-release-3.0.x`.
# Remove the local backport branch
git switch main
git branch -D backport-17269-to-release-3.0.x |
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Mitch Nemirovsky <7938872+mitchnemirov@users.noreply.github.com> (cherry picked from commit 70de523)
6 tasks
loki-gh-app Bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
Signed-off-by: Mitch Nemirovsky <7938872+mitchnemirov@users.noreply.github.com> (cherry picked from commit 70de523)
6 tasks
This was referenced Jun 24, 2025
This was referenced Jul 7, 2025
This was referenced Jul 21, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
Signed-off-by: Mitch Nemirovsky <7938872+mitchnemirov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected keep-file description true and false notes.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR