fix(helm): add flush=true to preStop hook - #16063
Conversation
|
Thanks for your PR. Could you please:
|
e2fd29f to
36a08aa
Compare
|
According to the Loki docs,
I define my own /ingester/shutdown lifecycle prestop hook on my single-AZ distrbuted mode ingesters, so I'm curious why this change was needed and if I would need it also. |
|
I followed the documentation https://github.com/grafana/loki/blob/main/docs/sources/operations/storage/wal.md#how-to-scale-updown that explicit mentions the endpoint with flush=true, but it did mention that the parameter is enabled by default. So your right, technically is not necessary, but it clarifies the situation. Feel free to create a PR for the single-AZ distrbuted mode ingesters. |
Co-authored-by: J Stickler <julie.stickler@grafana.com>
What this PR does / why we need it:
WAL needs to be flushed per https://github.com/grafana/loki/blob/main/docs/sources/operations/storage/wal.md#how-to-scale-updown
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR