feat(helm): adds a flag for tokengen rbac components so that they can be disabled optionally - #15882
Merged
Conversation
|
|
github-actions
Bot
added
area/helm
type/docs
Contributor
|
@drew0ps I think your pull request makes sense. Can you resolve the conflicts? |
Contributor
Author
Branch has been rebased - Conflicts should be solved. |
Contributor
|
LGTM |
Contributor
Author
|
@QuentinBisson - Your suggestion has been implemented. Do let me know if we require any more changes for an approval. |
Contributor
|
Thank you for your work. Te Loki team is fixing the ci workflows right now but i'll let you know if you need to do anything |
Contributor
|
@drew0ps can you fix the merge conflicts? |
… be disabled optionally
Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Signed-off-by: Adam Marton <ad.marton@proton.me>
Contributor
Author
Branch has been rebased |
Contributor
|
Awesome thanks |
Contributor
|
LGTM |
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Jayclifford345
approved these changes
Aug 1, 2025
This was referenced Nov 3, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
… be disabled optionally (grafana#15882) Signed-off-by: Adam Marton <ad.marton@proton.me> Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the option to disable the RBAC manifests from the tokengen component. This is needed for enterprise kubernetes offerings where developers/service owners are not allowed to deploy rbac related manifests, only specific workload related ones. In such cases, deploying the RBAC manifests are typically done separately after approval or by an infrastructure team.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR