feat(helm): Expose labels on volumeClaimTemplates - #13317
Merged
Conversation
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Contributor
Author
|
rebased |
github-actions
Bot
added
the
type/docs
Contributor
Author
|
updated |
Contributor
Author
|
merged from main |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Contributor
|
@jkroepke could you please resolve the conflicts and take a look at my comments? |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Contributor
Author
|
Done 👍 |
Contributor
|
Nice work @jkroepke. LGTM |
Contributor
|
@JStickler we're good with this one |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Jayclifford345
approved these changes
Jul 29, 2025
Jayclifford345
enabled auto-merge (squash)
July 29, 2025 09:28
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
This was referenced Nov 3, 2025
felix0102
pushed a commit
to felix0102/loki
that referenced
this pull request
Aug 2, 2026
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de> Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com> Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Velero resource filter based on labels.
https://velero.io/docs/main/resource-filtering/
In my use-case I want to exclude PVC from writer nodes (only used as WAL) from backup.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR