Skip to content

[AI-9953] Chore: PRs lack video proof verify steps - #124

Merged
matipojo merged 1 commit into
masterfrom
AI-9953-video-proof-demo
Oct 26, 2026
Merged

matipojo merged 1 commit into
masterfrom
AI-9953-video-proof-demo

Conversation

@matipojo

Copy link
Copy Markdown
Member

Problem

Video proof uses the PR description as its only task, but nothing in this repo tells authors or agents how to write that section.

Solution

New AGENTS.md that points to the shared angie-dev-tools video-proof-demo skill (elementor/angie-dev-tools#39), with a one-line Cursor plugin install note.

Video proof demo

Where: the product editor demo page
Steps: open the demo page → click Ask Angie → confirm the sidebar opened → capture screenshot
Pass: the Angie sidebar is visible next to the demo page
Fail: blank page, error page, or the sidebar does not open

Jira: https://elementor.atlassian.net/browse/AI-9953

@cloud-devpos

Copy link
Copy Markdown
Contributor

Review Summary

✅ Documentation-only PR adding AGENTS.md with PR description and video-proof workflow notes. No application code changed; nothing to flag under code-quality rules.


🤖 Code Style Review Agent

github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@github-actions

Copy link
Copy Markdown

🎬 Video Proof Test Results

Branch: AI-9953-video-proof-demo
Test Status: ✅ Passed

Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC.

📸 Screenshots

01
01

02
02

03
03

Artifacts are also available on the workflow run.

github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@cloud-devpos

cloud-devpos commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

PR adds a new AGENTS.md documentation file with agent instructions for PR descriptions, and is low-risk with all CI checks passing.

Reasons to auto-merge

  • All CI checks passed: CodeQL, tests (node 24), videoproof, Wiz scanners (data, IaC, SAST, secret, vulnerability) all green
  • Change is purely additive — a single new markdown documentation file (AGENTS.md) with 7 lines
  • No code changes: no logic, no security surface, no data handling affected
  • Clear, bounded purpose: establishes agent/PR workflow conventions for the repository
  • Follows existing pattern seen in angie-dev-tools (same AGENTS.md content used as a workspace rule there)
  • No open change-request reviews; pre-check verdict is PASS

Reasons not to auto-merge

  • No material risks identified — documentation-only change with no executable code

Verdict

Would auto-merge: Yes — this PR looks low-risk and merge-ready.


🤖 PR Approver Agent

@cloud-devpos

Copy link
Copy Markdown
Contributor

Review Summary

✅ Documentation-only PR that adds AGENTS.md with PR video-proof guidance for Cursor agents. No application code changed; markdown is excluded from test coverage and presents no code-quality issues in scope.


🤖 Code Style Review Agent

@cloud-devpos cloud-devpos added architect-reviewed PR has been automatically reviewed by CI (architect) auto-reviewed PR has been automatically reviewed by CI (auto) labels Oct 26, 2026
@matipojo
matipojo marked this pull request as ready for review October 26, 2026 18:29
@matipojo
matipojo merged commit 0c83ccc into master Oct 26, 2026
13 of 14 checks passed
@matipojo
matipojo deleted the AI-9953-video-proof-demo branch October 26, 2026 18:29
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

Verdict: ✅ Would auto-merge · Confidence: High

Adds a new AGENTS.md documentation file with PR description guidelines; purely additive, no code changes.

✅ No reasons not to auto-merge

Action: Safe to merge.

Why it still passes (5 signals)
  • All CI checks passed including CodeQL, Wiz scanners, and tests
  • Change is purely additive documentation — a single new markdown file with 7 lines
  • No code, configuration, secrets, or infrastructure touched
  • Follows the same AGENTS.md convention already present in elementor/angie-dev-tools
  • Zero risk of regression or data impact

🤖 PR Approver Agent · updated after 05fdb7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 min review architect-reviewed PR has been automatically reviewed by CI (architect) auto-reviewed PR has been automatically reviewed by CI (auto)

2 participants