Skip to content

[AI-9939] Chore: Video proof takes its task from the PR description - #123

Merged
matipojo merged 3 commits into
masterfrom
AI-9939-videoproof-pr-description
Oct 26, 2026
Merged

matipojo merged 3 commits into
masterfrom
AI-9939-videoproof-pr-description

Conversation

@matipojo

Copy link
Copy Markdown
Member

Problem

angie-dev-tools#33 makes the PR description the only video proof task and requires a PR number. angie-sdk still passes .github/videoproof-task.txt and allows video proof on workflow_dispatch, where there is no PR.

Solution

Delete .github/videoproof-task.txt, its VIDEO_PROOF_TASK_FILE env line, and the workflow_dispatch trigger of videoproof-ci.yml.

Test

On http://127.0.0.1:8080/demo/load-sidebar-v2-full-config/ click Ask Angie (#demo-toggle). Pass if the right-hand Angie sidebar opens, including a "Sign in to Angie" screen.

Video proof fails on this PR until angie-dev-tools#33 merges, because angie-dev-tools master still requires the task file.

Jira: https://elementor.atlassian.net/browse/AI-9939

@cloud-devpos

Copy link
Copy Markdown
Contributor

Review Summary

✅ Focused CI cleanup: removes the repo-specific videoproof task file and related workflow wiring so Videoproof-CI relies on the angie-dev-tools kit defaults. No application code or testable product paths changed.


🤖 Code Style Review Agent

@cloud-devpos cloud-devpos added auto-reviewed PR has been automatically reviewed by CI (auto) architect-reviewed PR has been automatically reviewed by CI (architect) labels Oct 26, 2026
github-actions Bot added a commit that referenced this pull request Oct 26, 2026
github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@github-actions

Copy link
Copy Markdown

🎬 Video Proof Test Results

Branch: AI-9939-videoproof-pr-description
Test Status: ✅ Passed

Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC.

📸 Screenshots

01
01

02
02

03
03

Artifacts are also available on the workflow run.

github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

Pre-checks did not pass — auto-merge evaluation stopped.

Reasons to auto-merge

  • None identified

Reasons not to auto-merge

  • PR is still a draft

Verdict

Would auto-merge: No — pre-checks blocked evaluation.

Fix the issues above, then push new commits to re-run.


🤖 PR Approver Agent

@cloud-devpos

Copy link
Copy Markdown
Contributor

Review Summary

✅ Focused CI workflow updates: videoproof no longer uses a repo-local task file or manual dispatch, and PR reviewer dispatch passes a draft flag. No application code changes; config-only diff with no code-quality issues in scope.


🤖 Code Style Review Agent

@cloud-devpos cloud-devpos added architect-reviewed-draft PR has been automatically reviewed by CI (architect, draft) auto-reviewed-draft PR has been automatically reviewed by CI (auto, draft) labels Oct 26, 2026
github-actions Bot added a commit that referenced this pull request Oct 26, 2026
github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@github-actions

Copy link
Copy Markdown

🎬 Video Proof Test Results

Branch: AI-9939-videoproof-pr-description
Test Status: ✅ Passed

Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC.

📸 Screenshots

01
01

02
02

03
03

Artifacts are also available on the workflow run.

github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

Pre-checks did not pass — auto-merge evaluation stopped.

Reasons to auto-merge

  • None identified

Reasons not to auto-merge

  • PR is still a draft

Verdict

Would auto-merge: No — pre-checks blocked evaluation.

Fix the issues above, then push new commits to re-run.


🤖 PR Approver Agent

github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@github-actions

Copy link
Copy Markdown

🎬 Video Proof Test Results

Branch: AI-9939-videoproof-pr-description
Test Status: ✅ Passed

Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC.

📸 Screenshots

01
01

02
02

Artifacts are also available on the workflow run.

github-actions Bot added a commit that referenced this pull request Oct 26, 2026
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

Pre-checks did not pass — auto-merge evaluation stopped.

Reasons to auto-merge

  • None identified

Reasons not to auto-merge

  • PR is still a draft

Verdict

Would auto-merge: No — pre-checks blocked evaluation.

Fix the issues above, then push new commits to re-run.


🤖 PR Approver Agent

@matipojo
matipojo marked this pull request as ready for review October 26, 2026 17:46
@matipojo
matipojo requested a review from a team as a code owner October 26, 2026 17:46
@matipojo
matipojo merged commit 48cf280 into master Oct 26, 2026
14 checks passed
@matipojo
matipojo deleted the AI-9939-videoproof-pr-description branch October 26, 2026 17:46
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

PR removes the videoproof task file and its CI workflow reference, plus removes workflow_dispatch trigger — CI workflow changes require human review per escalation policy.

Reasons to auto-merge

  • All CI checks passed (CodeQL, Wiz scanners, tests, videoproof-CI)
  • Pre-check verdict is PASS with no blockers
  • Diff is small and scoped (2 files, deletions only)
  • No security, auth, secrets, or data-integrity concerns in changed code
  • No application logic modified

Reasons not to auto-merge

  • CI workflow file (.github/workflows/videoproof-ci.yml) was modified — per escalation policy, Helm charts, CI workflows, and deployment configuration changes require human review
  • Removing VIDEO_PROOF_TASK_FILE env var from the workflow may silently break the videoproof run.sh script if it falls back to a default path that doesn't exist
  • Removing workflow_dispatch trigger removes the ability to manually trigger videoproof CI, which may affect debugging workflows — intent should be confirmed by a human

Verdict

Would auto-merge: No — human review is required.

Please request review from rnd-ai-advanced@elementor.com.


🤖 PR Approver Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 min review architect-reviewed PR has been automatically reviewed by CI (architect) architect-reviewed-draft PR has been automatically reviewed by CI (architect, draft) auto-reviewed PR has been automatically reviewed by CI (auto) auto-reviewed-draft PR has been automatically reviewed by CI (auto, draft) 🗑️ Deleted files

2 participants