Skip to content

Commit cd45c21

Browse files
author
Kent C. Dodds
committed
make shared work nicely... hopefully
1 parent 71a43b5 commit cd45c21

17 files changed

Lines changed: 51 additions & 45 deletions

File tree

‎client/other/shared‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
/Users/kdodds/Developer/testing-workshop/shared

‎client/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
"enzyme-to-json": "^3.3.0",
3535
"lodash.pick": "^4.4.0",
3636
"react-scripts": "^2.0.0-next.9754a231",
37-
"react-test-renderer": "^16.2.0"
37+
"react-test-renderer": "^16.2.0",
38+
"til-shared": "file:other/shared"
3839
},
3940
"browserslist": {
4041
"development": [

‎client/test/client-test-utils.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react'
22
import {Router} from 'react-router-dom'
33
import {mount} from 'enzyme'
44
import {createMemoryHistory} from 'history'
5-
import * as generate from '../../other/generate'
5+
import * as generate from 'til-shared/generate'
66

77
function mountWithRouter(ui, {route = '/'} = {}) {
88
const history = createMemoryHistory({initialEntries: [route]})

‎cypress/utils.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as generate from '../other/generate'
1+
import * as generate from '../shared/generate'
22

33
function loginAsNewUser() {
44
return createNewUser().then(user => {

‎package.json‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,8 @@
2929
"lint": "eslint . --cache --cache-location node_modules/.cache/eslint",
3030
"validate": "concurrently --names \"lint,test:coverage,test:e2e\" --prefix \"[{name}]\" --prefix-colors \"bgGreen.reset.bold,bgBlue.reset.bold,bgRed.reset.bold\" \"npm run lint --silent\" \"npm run test:coverage --silent\" \"npm run test:e2e --silent\"",
3131
"precommit": "lint-staged && npm run --silent validate",
32-
"clean": "rimraf node_modules ./client/node_modules ./server/node_modules",
33-
"setup": "node ./scripts/verify && node ./scripts/install && npm run validate",
34-
"now-build": "cd server && npm install",
35-
"now-start": "node ./server"
36-
},
37-
"now": {
38-
"name": "til",
39-
"alias": "til.now.sh",
40-
"files": [
41-
"./server",
42-
"./shared"
43-
]
44-
},
45-
"dependencies": {
46-
"jsonwebtoken": "^8.1.1"
32+
"clean": "rimraf node_modules ./shared/node_modules ./client/node_modules ./server/node_modules",
33+
"setup": "node ./scripts/verify && node ./scripts/install && npm run validate"
4734
},
4835
"devDependencies": {
4936
"all-contributors-cli": "^4.10.1",

‎scripts/deploy.sh‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
npm i -g now@9
2-
now -e NODE_ENV=production --token $NOW_TOKEN --npm deploy --public
3-
now alias --token=$NOW_TOKEN
1+
cd server
2+
npx --package now@9 --call \
3+
"now -e NODE_ENV=production --token $NOW_TOKEN --npm deploy --public && now alias --token=$NOW_TOKEN"

‎scripts/install.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@ var path = require('path')
44
var installDeps = require('./workshop-setup').installDeps
55

66
var main = path.resolve(__dirname, '..')
7+
var shared = path.resolve(__dirname, '../shared')
78
var server = path.resolve(__dirname, '../server')
89
var client = path.resolve(__dirname, '../client')
9-
installDeps([main, server, client]).then(
10+
installDeps([main, shared, server, client]).then(
1011
function() {
1112
console.log('👍 all dependencies installed')
1213
},

‎server/__tests__/auth.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import faker from 'faker'
21
import axios from 'axios'
32
import db from '../src/db'
43
// eslint-disable-next-line
@@ -23,7 +22,7 @@ afterAll(async () => {
2322
})
2423

2524
beforeEach(async () => {
26-
testUser = generate.userData({id: faker.random.uuid()})
25+
testUser = generate.userData({id: generate.id()})
2726
await resetDb({testUser})
2827
const token = getUserToken(testUser)
2928
authAPI = axios.create({baseURL})

‎server/__tests__/posts.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import faker from 'faker'
21
import axios from 'axios'
32
// eslint-disable-next-line
43
import {resetDb, generate} from 'server-test-utils'
@@ -21,7 +20,7 @@ afterAll(async () => {
2120
})
2221

2322
beforeEach(async () => {
24-
testUser = generate.userData({id: faker.random.uuid()})
23+
testUser = generate.userData({id: generate.id()})
2524
mockData = await resetDb({testUser})
2625
const token = getUserToken(testUser)
2726
authAPI = axios.create({baseURL})

‎server/other/shared‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
/Users/kdodds/Developer/testing-workshop/shared

0 commit comments

Comments
 (0)